21 2008-08-31 06:23:00 -0700 MSYS detection fails if MSYS was not installed via installer 2008-08-31 20:45:18 -0700 1 1 1 Unclassified pygame packaging 1.8 PC Windows RESOLVED FIXED P5 minor --- 1 Paul.Hampson brian len-l 55 12 Paul.Hampson 2008-08-31 06:23:39 -0700 Created attachment 12 Patch to fix MSYS detection when MSYS was not installed by the installer The MSYS detection code in msys.py, specifically find_msys_registry(), attempts to find the directory the MSYS installer's uninstall entry has recorded in the Windows Registry, raising a LookupError exception if no result was found which allows higher code to fall back to prompting the user. However, the call to _winreg.OpenKey is outside the try/except block, so if the key does not exist the wrong exception is thrown, and setup.py aborts without ever offering the prompt. The attached patch corrects this, by ensuring that the OpenKey is performed inside the outer try block, and the outer try block raises a LookupError on an exception. The inner try block is still necessary to ensure that the finally clause is run if we successfully OpenKeyed. 56 len-l 2008-08-31 20:45:18 -0700 Thanks for the report. Fixed in SVN revision 1644 12 2008-08-31 06:23:00 -0700 2008-08-31 06:23:39 -0700 Patch to fix MSYS detection when MSYS was not installed by the installer msysdetect.patch text/plain 793 Paul.Hampson LS0tIG1zeXMucHkub3JnCTIwMDgtMDctMDcgMTU6NTg6NDAgKzEwMDAKKysrIG1zeXMucHkJMjAw OC0wOC0zMSAyMzowODo0NCArMTAwMApAQCAtODYsMTQgKzg2LDE2IEBACiAgICAgCiAgICAgc3Vi a2V5ID0gKAogICAgICAgICAnU29mdHdhcmVcXE1pY3Jvc29mdFxcV2luZG93c1xcQ3VycmVudFZl cnNpb25cXFVuaW5zdGFsbFxcTVNZUy0xLjBfaXMxJykKLSAgICBrZXkgPSBfd2lucmVnLk9wZW5L ZXkoX3dpbnJlZy5IS0VZX0xPQ0FMX01BQ0hJTkUsIHN1YmtleSkKICAgICB0cnk6CisgICAgICAg IGtleSA9IF93aW5yZWcuT3BlbktleShfd2lucmVnLkhLRVlfTE9DQUxfTUFDSElORSwgc3Via2V5 KQogICAgICAgICB0cnk6CiAgICAgICAgICAgICByZXR1cm4gX3dpbnJlZy5RdWVyeVZhbHVlRXgo a2V5LCAnSW5ubyBTZXR1cDogQXBwIFBhdGgnKVswXS5lbmNvZGUoKQogICAgICAgICBleGNlcHQg V2luZG93c0Vycm9yOgogICAgICAgICAgICAgcmFpc2UgTG9va3VwRXJyb3IoIk1TWVMgbm90IGZv dW5kIGluIHRoZSByZWdpc3RyeSIpCi0gICAgZmluYWxseToKLSAgICAgICAga2V5LkNsb3NlKCkK KyAgICAgICAgZmluYWxseToKKyAgICAgICAgICAgIGtleS5DbG9zZSgpCisgICAgZXhjZXB0IFdp bmRvd3NFcnJvcjoKKyAgICAgICAgcmFpc2UgTG9va3VwRXJyb3IoIk1TWVMgbm90IGZvdW5kIGlu IHRoZSByZWdpc3RyeSIpCiAKIGRlZiBhc19zaGVsbChtc3lzX3Jvb3QpOgogICAgICIiIkFwcGVu ZCBNU1lTIHNoZWxsIHByb2dyYW0gdG8gTVNZUyByb290IGRpcmVjdG9yeSBwYXRoIiIiCg==